Install phantom.js - Githubissues

ga-wdi-boston / orientation

Instructions for students beginning General Assembly's WDI program in Boston

Other

11 stars 198 forks source link

Install phantom.js #148

Closed RealWeeks closed 7 years ago

RealWeeks commented 8 years ago

For use during ember. Issue opened per @jrhorn424

RealWeeks commented 8 years ago

@jrhorn424

Deprecation warning for phantomjs:

DEPRECATED
Pre-2.0, this package was published to NPM as phantomjs. We changed the name to phantomjs-prebuilt at the request of PhantomJS team.

Please update your package references from phantomjs to phantomjs-prebuilt

Before I add this will going with prebuilt mess anything up with Ember that you are aware of?

jrhorn424 commented 8 years ago

No, but I'm not sure we get this warning anymore. I can leave open until you get to Ember in 013 and we can figure it out then.

laurenfazah commented 8 years ago

No phantomjs issues in ember prep for 013 @jrhorn424 @J-Weeks

RealWeeks commented 8 years ago

@jrhorn424 added this in commit 837f195. Thoughts? okay to close?