search

ga-wdi-boston / orientation

Instructions for students beginning General Assembly's WDI program in Boston
Other
11 stars 198 forks source link

Mention example files that are in orientation folder #239

Closed danman01 closed 7 years ago

danman01 commented 7 years ago

As a reference while going through installfest, developers can look at the orientation folders' example .bashrc and .bash_profile. This could be mentioned near the top and / or bottom of the installfest doc so that developers can ensure they've done everything correctly.

MicFin commented 7 years ago

Unfortunately the example .bashrc is not up to date. It should be checked against the current steps in installfest. I did not check the .bash_profile but it should likely be reviewed first too.

danman01 commented 7 years ago

This is the diff I see after browsing the steps in the INSTALLFEST.md.

If the example .bashrc and .bash_profile are worth updating, which I think they are, I can add these and submit a PR:

# hub
eval "$(hub alias -s)"

# Rbenv, before the git section
if which rbenv > /dev/null; then
 eval "$(rbenv init -)"
fi
jrhorn424 commented 7 years ago

@sdavidson140 Why wasn't this addressed?

jrhorn424 commented 7 years ago

@danman01 A PR would be appreciated.

scottyscripts commented 7 years ago

@jrhorn424 The hub.sh script adds eval "$(hub alias -s)" to .bashrc

The rbenv script adds if which rbenv > /dev/null; then eval "$(rbenv init -)" fi to .bashrc

scottyscripts commented 7 years ago

@jrhorn424 I don't know if it makes sense to have the examples anymore since we can be sure these steps are working in scripts.

jrhorn424 commented 7 years ago

The rbenv script adds if which rbenv > /dev/null; then eval "$(rbenv init -)" fi to .bashrc

@sdavidson140 Then find me a commit SHA.

jrhorn424 commented 7 years ago

I don't know if it makes sense to have the examples anymore since we can be sure these steps are working in scripts.

Open an issue for removal. Recommend whatever example files should be removed as you see fit.

scottyscripts commented 7 years ago

Moved to and closed on GHE https://git.generalassemb.ly/ga-wdi-boston/orientation/issues/239