search

ga4gh-beacon / beacon-elixir

Elixir Beacon Reference Implementation. Latest release is compliant with v1.1.0 of the specification.
https://beacon-project.io/
Other
14 stars 7 forks source link

Cannot handle datasets with call_cnt > 2147483647 #22

Closed bhosking closed 5 years ago

bhosking commented 5 years ago

The dataset call count is typically near 2 variant_count sample_count, and as such can sometimes be over the value that can be stored in an integer. I think the postgres data type should be changed to bigint, and the java type change to Long.

sdelatorrep commented 5 years ago

Hi! You're totally right. I found this issue in the EGA Beacon where we have millions of variants (and uses basically the same base code) but totally forgot to fix it in this repo. Thanks for spotting this!