galacean / engine

A typescript interactive engine, support 2D, 3D, animation, physics, built on WebGL and glTF.
https://galacean.antgroup.com/
MIT License
4.05k stars 289 forks source link

Improve GLSL ES3.00 shader syntax compatibility #2048

Closed zhuxudong closed 3 months ago

zhuxudong commented 3 months ago

Please check if the PR fulfills these requirements

Fix #2047

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.10%. Comparing base (6c06394) to head (09dea9d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2048 +/- ## ========================================== + Coverage 66.05% 66.10% +0.05% ========================================== Files 460 460 Lines 22996 23000 +4 Branches 3369 3369 ========================================== + Hits 15190 15205 +15 + Misses 6645 6631 -14 - Partials 1161 1164 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GuoLei1990 commented 3 months ago

Completed supplementary inspection: image

GuoLei1990 commented 3 months ago

image Babylon.js don't have this bug