search

galacean / engine

A typescript interactive engine, support 2D, 3D, animation, physics, built on WebGL and glTF.
https://galacean.antgroup.com/
MIT License
4.04k stars 289 forks source link

Fix sub asset repeated loading #2107

Closed zhuxudong closed 1 week ago

zhuxudong commented 1 month ago

Summary by CodeRabbit

GuoLei1990 commented 1 week ago

Try opt Promise count

GuoLei1990 commented 1 week ago

Create a issue with can't query sub asset array

coderabbitai[bot] commented 1 week ago

Walkthrough

The recent updates primarily focus on enhancing the ResourceManager and GLTFParserContext for managing sub-asset promises more efficiently and adjusting URL construction logic for asset processing. Key additions include methods for creating and releasing sub-asset promises and refining method parameters involving URL handling.

Changes

Files & Directories Change Summary
packages/core/src/asset/ResourceManager.ts Improved sub-asset promise management, added new methods for handling promises, and adjusted internal structures.
packages/loader/src/gltf/parser/GLTFParserContext.ts Refined URL construction logic for _onSubAssetSuccess method calls, improving resource handling.
tests/src/core/resource/ResourceManager.test.ts Added tests for new functionality, including AssetPromise and ResourceManager, with chai and chai-spies.

Sequence Diagram(s)

sequenceDiagram
    participant GLTFParserContext
    participant ResourceManager

    GLTFParserContext->>ResourceManager: call _onSubAssetSuccess(url, resourceKey, asset)
    ResourceManager->>ResourceManager: create sub-asset promise callback(resourceKey, asset)

    ResourceManager->>ResourceManager: store callback in _subAssetPromiseCallbacks
    ResourceManager-->>GLTFParserContext: promise resolved

    Note over GLTFParserContext, ResourceManager: Handle sub-asset success efficiently
    GLTFParserContext->>ResourceManager: call _onSubAssetFail(url, resourceKey)
    ResourceManager->>ResourceManager: release sub-asset promise callback(url)
    ResourceManager-->>GLTFParserContext: promise rejected

    Note over GLTFParserContext, ResourceManager: Handle sub-asset failure gracefully

Poem

🐰 In bytes and whispers, code unfurls, Glimmering paths in techie whirls. Resources managed, promises made, URLs crafted in logic's parade. The tests now spy, with chai delight, In these changes, functions take flight! 🚀

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (4b28345) to head (e556493). Report is 18 commits behind head on main.

Files Patch % Lines
packages/core/src/asset/ResourceManager.ts 52.63% 10 Missing and 8 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2107 +/- ## ========================================== + Coverage 66.09% 66.15% +0.06% ========================================== Files 460 461 +1 Lines 23013 23085 +72 Branches 3370 3404 +34 ========================================== + Hits 15211 15273 +62 + Misses 6637 6635 -2 - Partials 1165 1177 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.