Closed zhuxudong closed 3 months ago
@coderabbitai review
[!WARNING]
Review failed
The pull request is closed.
The overall changes focus on updating the SceneLoader and SceneSchema components to incorporate the textureFillMode
property for scene backgrounds. This update ensures that the BackgroundTextureFillMode
is imported and utilized within the SceneLoader class, setting it conditionally if available.
File(s) | Change Summary |
---|---|
packages/loader/src/SceneLoader.ts |
Assigned textureFillMode to background.textureFillMode if defined, using a conditional check. |
packages/loader/src/resource-deserialize/resources/schema/... | Updated import to include BackgroundTextureFillModeand added textureFillModeto IBackground` |
sequenceDiagram
participant User
participant SceneLoader
participant Scene
participant Background
User->>SceneLoader: Load Scene
SceneLoader->>Scene: Initialize Scene with Background
SceneLoader-->>Scene: Set background.textureFillMode if defined
Scene->>Background: Apply textureFillMode
By moonlit code and daytime byte,
The background now fills just right,
With texture modes both near and far,
It paints the scene, a rising star.
In schemas deep and loaders, clean,
We crafted well a wondrous scene.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
https://github.com/galacean/editor/pull/2717
Summary by CodeRabbit
textureFillMode
.