coderabbitai[bot]
commented
1 month ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The pull request introduces updates to the CI workflow and the testing framework, transitioning from Chai to Vitest. Key modifications include the removal of the codecov job in the CI configuration, changes to test scripts in package.json, and the introduction of a new Vitest configuration file. Several unused dependencies have been removed, and existing classes have been reformatted for improved readability without altering functionality.
Changes
| File Path | Change Summary |
|---|---|
| .github/workflows/ci.yml | Removed codecov job; corrected indentation in build job; modified e2e job to run Cypress tests with new artifact upload steps. |
| package.json | Updated test script to run vitest; added coverage script; added pretest script; removed several devDependencies and added new dependencies for vitest and playwright. |
| packages/core/src/animation/Keyframe.ts | Reformatted the generic type parameter T in the Keyframe class declaration for improved readability without changing logic. |
| packages/core/src/animation/internal/animationCurveOwner/AnimationCurveOwner.ts | Reformatted conditional expressions in evaluateCrossFadeValue and crossFadeFromPoseAndApplyValue methods for clarity while preserving logic. |
| tests/src/shader-lab/Preprocessor.test.ts | Updated import statements and changed testing framework from Chai to Vitest, including asynchronous file reading. |
| tests/src/shader-lab/test-case/index.ts | Transitioned to asynchronous file handling, updated import statements, and simplified path management. |
| tests/vitest.config.ts | Added a new Vitest configuration file to set up project-specific configurations, including dependency optimizations and browser settings. |
| e2e/package.json | Updated version number and changed vite dependency from caret version to fixed version. |
Possibly related PRs
-
2364: The changes in the
.github/workflows/ci.ymlfile regarding the build command and the removal of thecodecovjob are directly related to the modifications made in the same file in this PR, which also involves changes to the CI workflow configuration. -
2396: This PR also involves changes to the
.github/workflows/ci.ymlfile, including the removal of thecodecovjob and adjustments to thebuildande2ejobs, directly relating to the modifications in the main PR.
Suggested labels
enhancement
Suggested reviewers
- gz65555
Poem
In the land of code where rabbits play,
Our tests now hop in a brand new way.
With Vitest's charm, we leap and bound,
Chai's old ways no longer found.
Coverage and structure, all set to shine,
Hooray for our changes, oh how divine! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit
New Features
@galacean/engine-e2eproject version and fixed thevitedependency version.Bug Fixes
Chores
package.jsonto simplify coverage reporting and improve consistency in testing practices.