coderabbitai[bot]
commented
3 weeks ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The changes in this pull request focus on enhancing the animation system within the Animator class and related components. Key modifications include improvements to animation state transitions, playback timing, and the introduction of new methods for calculating clip start and end times. Adjustments were made to how frame time is handled during updates, and new test cases were added to validate the functionality of these changes.
Changes
| File Path | Change Summary |
|---|---|
packages/core/src/animation/Animator.ts |
- Updated exit time and clip duration calculations for transitions. - Modified _updatePlayingState to use _getClipActualEndTime().- Refined cross-fade logic with playedTime adjustments.- Method signatures updated for play, crossFade, setParameterValue to include return types. |
packages/core/src/animation/AnimatorState.ts |
- Added _getClipActualStartTime and _getClipActualEndTime methods for precise timing calculations. |
packages/core/src/animation/internal/AnimatorStatePlayData.ts |
- Introduced offsetFrameTime property and updated reset method signature to accept it.- Modified update method to incorporate offsetFrameTime in frame time calculations. |
tests/src/core/Animator.test.ts |
- Added tests for animator transitions with offsets and for cross-fade behavior with clip start times. |
Possibly related PRs
- #2359: Enhances the management of state transitions and improves the calculation of play cost time during animations.
- #2377: Introduces support for fixed duration transitions in the Animator, aligning with updates to transition logic and timing calculations.
- #2392: Adds methods for calculating actual start and end times of animation clips, directly relating to the precision of transition timing and playback.
Suggested labels
animation
Suggested reviewers
- GuoLei1990
Poem
In the world of hops and plays,
Animations dance through sunny rays.
With timing sharp and transitions smooth,
Our Animator finds its groove!
So let us cheer with joyful glee,
For smoother animations, wild and free! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit