search

galacean / engine

A typescript interactive engine, support 2D, 3D, animation, physics, built on WebGL and glTF.
https://www.galacean.com/engine
MIT License
4.29k stars 307 forks source link

Merge main branch #2415

Closed luzhuang closed 4 weeks ago

luzhuang commented 4 weeks ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 4 weeks ago

[!WARNING]

Rate limit exceeded

@luzhuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between 137110e136e4e0601bb6a8997b4b9fc17dd43248 and 367d5b24d2dd4320893020a55dc51d026b87f36a.

Walkthrough

This pull request includes various updates across multiple files, primarily focusing on documentation improvements, version updates, and code refinements. Key changes involve correcting typographical errors in the contribution guide, enhancing clarity in the Spine animation documentation, and updating version numbers in several package.json files from an experimental version to a stable release. Additionally, modifications to the Animator class and its tests reflect improved logic for animation playback and state transitions.

Changes

File Change Summary
.github/HOW_TO_CONTRIBUTE.md Corrected "Code of Conductor" to "Code of Conduct", fixed typos, and made formatting adjustments.
.github/workflows/release.yml Updated action from gz65555/publish@v0.1.9 to galacean/publish@v0.2.0.
docs/en/graphics/2D/spine/editor.md Updated title, refined structure, clarified asset import/export instructions, and added project export section.
docs/zh/art/digital-human.md New documentation added for the "Digital Human Project," detailing model creation, rendering, and animation.
docs/zh/graphics/texture/compression.md Updated KTX2 texture usage details, added compatibility notes, and improved code snippet formatting.
e2e/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/core/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/core/src/Engine.ts Modified _getShaderProgramPool to pass this to ShaderProgramPool constructor.
packages/core/src/animation/Animator.ts Updated state transition logic and animation event handling for improved accuracy.
packages/core/src/animation/internal/AnimatorStatePlayData.ts Renamed frameTime to playedTime, added offsetFrameTime, and adjusted related methods.
packages/core/src/shader/ShaderPass.ts Enhanced cleanup process in _destroy method for shader program pools.
packages/core/src/shader/ShaderProgramPool.ts Added constructor to ShaderProgramPool to accept Engine instance.
packages/design/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/galacean/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/loader/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/math/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/physics-lite/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/physics-physx/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/rhi-webgl/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/shader-lab/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/xr-webxr/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
packages/xr/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
tests/package.json Updated version from "0.0.0-experimental-1.3-xr.10" to "1.3.15".
tests/src/core/Animator.test.ts Updated test cases to reflect changes in Animator class, added new tests for transition offsets and clip start times.

Possibly related PRs

Suggested labels

bug, animation, test

Suggested reviewers

🐇 In the meadow, changes abound,
With fixes and updates, joy is found.
From typos corrected to versions anew,
Our code is now clearer, and so much more true!
Let's hop with delight, for progress is here,
In the world of coding, we cheer and we cheer! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 38.59649% with 35 lines in your changes missing coverage. Please review.

Project coverage is 66.67%. Comparing base (137110e) to head (367d5b2). Report is 20 commits behind head on dev/1.4.

Files with missing lines Patch % Lines
examples/shader-lab-multi-pass.ts 0.00% 31 Missing :warning:
packages/core/src/shader/ShaderPass.ts 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev/1.4 #2415 +/- ## ======================================== Coverage 66.67% 66.67% ======================================== Files 895 895 Lines 92090 92094 +4 Branches 7274 7280 +6 ======================================== + Hits 61397 61404 +7 + Misses 30448 30445 -3 Partials 245 245 ``` | [Flag](https://app.codecov.io/gh/galacean/engine/pull/2415/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=galacean) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/galacean/engine/pull/2415/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=galacean) | `66.67% <38.59%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=galacean#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.