Closed GuoLei1990 closed 3 weeks ago
The pull request modifies the MainModule
class in MainModule.ts
by changing the visibility of the _tempVector40
variable from private static
to private
, transitioning it from a class-level to an instance-level variable. Additionally, the _updateShaderData
method has been updated to use the instance variable this._tempVector40
, which is now assigned via the copyFrom
method. The overall control flow and logic of the class remain unchanged, with no new methods or alterations to existing method signatures.
File Path | Change Summary |
---|---|
packages/core/src/particle/modules/MainModule.ts | - Changed _tempVector40 visibility from private static to private . |
- Updated _updateShaderData to use instance variable this._tempVector40 instead of static. |
ShaderProgramPool
class involve modifications to how shaders are managed, which may relate to the overall handling of particle systems and their shaders in the MainModule
, particularly in how instance variables are utilized.In the module where particles play,
A vector's shift brightens the day.
From static to instance, it found its way,
Each bunny now hops with less delay! 🐇✨
With shaders dancing, oh what a sight,
In the code's embrace, everything feels right!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit
New Features
MainModule
, allowing for better state handling.Bug Fixes
MainModule
to ensure consistent behavior across instances.