Fix renderQueueType error

[zhuxudong]

Please check if the PR fulfills these requirements

• [x] The commit message follows our guidelines
• [ ] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug Fix.

What is the current behavior? (You can also link to an open issue here)

ShaderPass's renderQueueType will be override by BasicRenderPipeline.pushRenderElementByType

What is the new behavior (if this is a feature change)?

Should Correct true renderQueueType before render.

Summary by CodeRabbit

• Improvements
  • Enhanced clarity and control flow in the rendering process, leading to more predictable behavior with shader passes.
  • Streamlined handling of render states for improved performance and maintainability.
  • Updated logic for determining render queue types, potentially improving rendering categorization.
  • Introduced a new ShaderLab rendering state configuration for WebGL, enhancing rendering capabilities.
• Bug Fixes
  • Simplified logic for applying render states to ensure accurate rendering outcomes.

[coderabbitai[bot]]

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request enhance the logic within the RenderQueue, BasicRenderPipeline, and RenderState classes. The render method in RenderQueue.ts has been modified to clarify the handling of render states and queue types. In BasicRenderPipeline.ts, the method for determining render queue types has been updated, affecting how render elements are categorized. Additionally, the RenderState class has seen a method rename and a shift in functionality to return a computed render queue type. Overall, these changes improve code clarity and maintainability without altering the fundamental structure.

Changes

File Path	Change Summary
packages/core/src/RenderPipeline/RenderQueue.ts	Enhanced render method logic by clarifying renderState and simplifying conditional checks.
packages/core/src/RenderPipeline/BasicRenderPipeline.ts	Updated pushRenderElementByType method to use _getRenderQueueByShaderData, refining render queue type determination.
packages/core/src/shader/state/RenderState.ts	Renamed _applyRenderQueueByShaderData to _getRenderQueueByShaderData, changing its return type to RenderQueueType and altering its internal logic.
e2e/case/shaderLab-renderState.ts	Introduced new file for ShaderLab rendering state configuration with shader setup and entity creation.
e2e/config.ts	Added new entry "shaderLab-renderState" to E2E_CONFIG for end-to-end testing configuration.

Possibly related PRs

• #2129: The changes in the BasicRenderPipeline class regarding the render queue type determination may relate to the modifications in the RenderQueue class's render method, as both involve handling render queue types and shader data.
• #2369: The refactor of the RenderQueue class's rendering logic, particularly in relation to mask interactions, could be relevant to the changes made in the RenderQueue class in the main PR, as both involve rendering logic and queue management.
• #2378: The improvements in ShaderLab's compatibility with RenderState may connect to the changes in the RenderQueue class, as both involve shader state management and rendering processes.
• #2414: The updates to the BasicRenderPipeline class's rendering methods, particularly regarding shader data and camera integration, may relate to the changes in the RenderQueue class's handling of shader passes and render states.
• #2427: The modifications in the MaterialLoader class regarding shader retrieval may connect to the changes in the RenderQueue class, as both involve shader management and rendering processes.

Suggested labels

Rendering, shader, high priority

Suggested reviewers

• GuoLei1990
• Sway007

🐇 In the realm of code where the shaders play,
The RenderQueue shines in a clearer way.
With states refined and logic tight,
Our rendering path is now more bright!
So hop along, let the pixels gleam,
In this code garden, we build our dream! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.77%. Comparing base (7da32a5) to head (02b8e40). Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/core/src/RenderPipeline/RenderQueue.ts	85.71%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2437 +/- ## ========================================== + Coverage 69.44% 70.77% +1.33% ========================================== Files 524 524 Lines 27484 27487 +3 Branches 4112 4111 -1 ========================================== + Hits 19085 19453 +368 + Misses 6894 6479 -415 - Partials 1505 1555 +50 ``` | [Flag](https://app.codecov.io/gh/galacean/engine/pull/2437/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=galacean) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/galacean/engine/pull/2437/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=galacean) | `70.77% <91.66%> (+1.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=galacean#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.