galasa-dev / projectmanagement

Project Management repo for Issues and ZenHub
7 stars 4 forks source link

CLI: Galasactl project create --package should allow mixed-case package names. #1815

Closed techcobweb closed 5 months ago

techcobweb commented 5 months ago

Hi all, got a question on galasactl project create:

galasactl project create --obr --gradle --package com.ibm.cics.demopackage --features myfeature1,myfeature2

As I understand it, an osgi package name needs to be all lower case. I think this line in the --help for galasactl project create: --features string A comma-separated list of features you are testing. These must be able to form parts of a java package name. For example: "payee,account" (default "feature1")

implies that the features names must all be lower case with the line "These must be able to form parts of a java package name". I get this error on creating a feature with a capital letter in it:

$ galasactl project create --obr --gradle --package com.ibm.cics.demopackage 
--features myFeature
Error: GAL1045E: Invalid feature name. Feature name 'myFeature' cannot be used as a java package
name. 
'GAL1037E: Invalid Java package name 'myFeature' should not contain the 'F' character. 
Use the --help flag for more information, or refer to the documentation at
https://galasa.dev/docs/reference/cli-commands.'

Which highlights the capital "F". I think it might be good to explicitly state that caps are not allowed in one of the messages.

It seems to me like a good approach would be for galasactl to allow you to input feature names in a list with capitalisation, then to convert to lower case for the package names?

techcobweb commented 5 months ago

Tom says:

Right I see, that makes sense.

Closing as a result.