search

galasa-dev / projectmanagement

Project Management repo for Issues and ZenHub
7 stars 4 forks source link

Inttests failure (tests that run ZosManagerFileDatasetIVT): `Data set "X" is not a partitioned data set` #1830

Closed jadecarino closed 5 months ago

jadecarino commented 5 months ago

Describe the bug

Since Wednesday 27th March there has been a large number of our integration tests failing. Every day we get a handful of the integration tests that run the ZosManagerFileDatasetIVT failing with the following exception:

----------------------- ****************************************************************************************************
----------------------- *** Failed - Test method dev.galasa.zos.manager.ivt.ZosManagerFileDatasetIVT#datasetAttributeCheck,type=Test
----------------------- ****************************************************************************************************
dev.galasa.zosfile.ZosDatasetException: Unable to create LISTDSI EXEC command
    at dev.galasa.zosfile.rseapi.manager.internal.RseapiZosDatasetAttributesListdsi.initialise(RseapiZosDatasetAttributesListdsi.java:116)
    at dev.galasa.zosfile.rseapi.manager.internal.RseapiZosDatasetAttributesListdsi.get(RseapiZosDatasetAttributesListdsi.java:122)
    at dev.galasa.zosfile.rseapi.manager.internal.RseapiZosDatasetImpl.retrieveAttibutes(RseapiZosDatasetImpl.java:716)
    at dev.galasa.zos.manager.ivt.ZosManagerFileDatasetIVT.datasetAttributeCheck(ZosManagerFileDatasetIVT.java:169)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    at dev.galasa.framework.GenericMethodWrapper.invoke(GenericMethodWrapper.java:88)
    at dev.galasa.framework.TestMethodWrapper.invoke(TestMethodWrapper.java:61)
    at dev.galasa.framework.TestClassWrapper.runTestMethods(TestClassWrapper.java:213)
    at dev.galasa.framework.TestRunner.runTestClassWrapper(TestRunner.java:607)
    at dev.galasa.framework.TestRunner.runEnvironment(TestRunner.java:581)
    at dev.galasa.framework.TestRunner.createEnvironment(TestRunner.java:546)
    at dev.galasa.framework.TestRunner.generateEnvironment(TestRunner.java:503)
    at dev.galasa.framework.TestRunner.runTest(TestRunner.java:424)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    at dev.galasa.boot.felix.FelixFramework.runTest(FelixFramework.java:234)
    at dev.galasa.boot.Launcher.launch(Launcher.java:176)
    at dev.galasa.boot.Launcher.main(Launcher.java:126)
Caused by: dev.galasa.zosfile.ZosDatasetException: Data set "X" is not a partitioned data set
    at dev.galasa.zosfile.rseapi.manager.internal.RseapiZosDatasetImpl.memberExists(RseapiZosDatasetImpl.java:401)
    at dev.galasa.zosfile.rseapi.manager.internal.RseapiZosDatasetAttributesListdsi.createExecDataset(RseapiZosDatasetAttributesListdsi.java:369)
    at dev.galasa.zosfile.rseapi.manager.internal.RseapiZosDatasetAttributesListdsi.initialise(RseapiZosDatasetAttributesListdsi.java:113)
    ... 22 more

There are six integration tests that run the ZosManagerFileDatasetIVT and they don't all fail every day so it can't be an error with the IVT or Manager that is guaranteed to happen every time the test is ran.

Ideas

Maybe an issue with the tests running at the same time, do they share a resource name? Maybe an issue with one of the characters in the resource name, as it uses the Galasa test run name?

Steps to reproduce

  1. Prepare a portfolio of tests.
  2. Remove all apart from the 6 tests above.
  3. Submit them.
  4. See error

Expected behavior

The tests should all Pass.

Additional context

If applicable, add screenshots or any relevant output logs to help explain your problem.

jadecarino commented 5 months ago

I have ran a portfolio of the six tests to attempt to recreate the defect and analyse the results, outside of them being ran as part of the regression pipeline. Results were:

submitted-time(UTC) name requestor  status  result test-name
2024-04-16 14:45:07 C876 jadecarino rundone Passed inttests/dev.galasa.inttests/dev.galasa.inttests.zosFileDataset.local.mvp.ZosFileDatasetLocalJava11UbuntuMvpZosmf
2024-04-16 14:45:07 C877 jadecarino rundone Passed inttests/dev.galasa.inttests/dev.galasa.inttests.zosFileDataset.local.ZosFileDatasetLocalJava11UbuntuZosmf
2024-04-16 14:45:07 C879 jadecarino rundone Passed inttests/dev.galasa.inttests/dev.galasa.inttests.zosFileDataset.local.ZosFileDatasetLocalJava11UbuntuRse
2024-04-16 14:45:07 C875 jadecarino rundone Passed inttests/dev.galasa.inttests/dev.galasa.inttests.zosFileDataset.local.isolated.ZosFileDatasetLocalJava11UbuntuIsolatedRse
2024-04-16 14:45:07 C874 jadecarino rundone Passed inttests/dev.galasa.inttests/dev.galasa.inttests.zosFileDataset.local.isolated.ZosFileDatasetLocalJava11UbuntuIsolatedZosmf
2024-04-16 14:45:07 C878 jadecarino rundone Failed inttests/dev.galasa.inttests/dev.galasa.inttests.zosFileDataset.local.mvp.ZosFileDatasetLocalJava11UbuntuMvpRse

Total:6 Passed:5 Failed:1
eamansour commented 5 months ago

Looked into this with Will and found a defect in the zosFile manager which I've raised an issue for (see https://github.com/galasa-dev/projectmanagement/issues/1849).

For now, we've manually deleted the EXEC datasets and the inttests running ZosManagerFileDatasetIVT now pass.