galasa-dev / projectmanagement

Project Management repo for Issues and ZenHub
7 stars 3 forks source link

Pull all CPS properties at the start of a run if using remote CPS #1889

Open Tom-Slattery opened 4 weeks ago

Tom-Slattery commented 4 weeks ago

Currently when using a remote CPS properties store in an ecosystem it looks like I'm seeing INFO d.g.c.r.RestCPS - galasacps: over rest each time a CPS property needs to be retrieved. I've noticed since changing to remote CPS the test takes a lot longer to run, I think this might be the result of it doing many individual REST calls to the API server. Would it be better to consolidate all of this into a single call where it retrieves the entire CPS properties from the ecosystem at the start of the test in a single REST call and then uses that for the runtime of the test? This might speed up the test run a lot

techcobweb commented 3 weeks ago

Yes it would speed tests up. Get them all and cache the values would be fine in theory.

Do you have any rough metrics between using REST vs the file system ? How painful is it ?

The trouble would be when the CPS gets to hold a large number of properties. There must be a balancing point when getting them individually is quicker. No idea just yet what that balancing point might be however.

Of course, getting anything in the secure namespace (secrets) won't work regardless.