Add spotbugs and pmd to framework

[techcobweb]

Story

As a galasa code developer I want to run modern tools against my code to find bugs before I deliver changes, so my code is better quality than it would otherwise be.

Background

Spotbugs and PMD are code checkers which work well against Java code.

Mark Lawrence checked an example into the manager recently. using this pr: https://github.com/galasa-dev/managers/pull/940

Lets try to get these tools working against all or part of the framework code to see if we can get value out of them.

Tasks

• [x] Add these into the framework gradle build and see what comes out.
• [x] Review the output with others in the team.
• [x] Local build fails if they find anything really bad.

[Wyvinar]

results from running pmd and spotbug on the dev.galasa.framework.api.authentication package Archive.zip

[techcobweb]

I think you configure vscode with a plugin to read those things when they are available ? The xml files are not very readable, so that would make it hard to consume the output. Can you pls try that to see if you can get any sense out of it ? @Mark-J-Lawrence can advise if you get stuck...

[Wyvinar]

working branch is: https://github.com/galasa-dev/framework/tree/holly-spotbug-iss1899