search

gandrade / assessment

🇩🇪 :oncoming_taxi: Backend Software Enginner applicant test for a hide-hailing company
https://mytaxi-assessment.herokuapp.com/
1 stars 0 forks source link

Refactoring Specification classes and tests; Creating a separate DTO … #16

Closed gandrade closed 4 years ago

gandrade commented 4 years ago

Refactoring Specification classes and tests; Creating a separate DTO for binding criteria queries

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will increase coverage by 2.72%. The diff coverage is 91.86%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     85.86%   88.58%   +2.72%     
- Complexity      152      183      +31     
============================================
  Files            29       32       +3     
  Lines           488      578      +90     
  Branches         20       22       +2     
============================================
+ Hits            419      512      +93     
+ Misses           59       58       -1     
+ Partials         10        8       -2
Impacted Files Coverage Δ Complexity Δ
...main/java/com/mytaxi/controller/CarController.java 100% <ø> (ø) 6 <0> (ø) :arrow_down:
...java/com/mytaxi/service/car/DefaultCarService.java 100% <ø> (ø) 12 <0> (ø) :arrow_down:
...ytaxi/core/configuration/SwaggerConfiguration.java 100% <ø> (ø) 5 <0> (?)
...taxi/core/configuration/SecurityConfiguration.java 100% <ø> (ø) 4 <0> (?)
...rc/main/java/com/mytaxi/core/mapper/CarMapper.java 96.87% <100%> (ø) 6 <2> (?)
...ification/ManufacturerDOSpecificationExecutor.java 100% <100%> (ø) 5 <4> (?)
...n/java/com/mytaxi/controller/DriverController.java 100% <100%> (ø) 9 <1> (ø) :arrow_down:
...om/mytaxi/service/driver/DefaultDriverService.java 97.29% <100%> (+0.15%) 14 <1> (ø) :arrow_down:
.../com/mytaxi/datatransferobject/CarCriteriaDTO.java 100% <100%> (ø) 10 <10> (?)
...xi/specification/DefaultSpecificationExecutor.java 100% <100%> (ø) 6 <6> (?)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77feff5...b7d1828. Read the comment docs.