search

gap-infra / integration

A repository for hosting GitHub Actions based GAP-package integration tests
1 stars 4 forks source link

pkg-tests.g: use our own variant of TestPackage #11

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

In GAP 4.11.1 the function is different; also our modified version does not fail packages without tests anymore.

fingolfin commented 2 years ago

Seems to be working as intended in my tests at https://github.com/fingolfin/integration/runs/5316588833?check_suite_focus=true and https://github.com/fingolfin/integration/runs/5316594778?check_suite_focus=true

So that should remove about 25 failing tests (out of 46) for package tests against GAP master

wilfwilson commented 2 years ago

Another technical solution for dealing with packages with a TestFile would be to to add some code to these lines: https://github.com/gap-infra/integration/blob/bab58c74245e62f060ed33eb975be41065188166/.github/workflows/pkg-tests.yml#L34-L38 to filter out those packages without a TestFile.

This way we only spawn a job for those packages with a TestFile (removing the concept of a package without TestFile somehow 'passing' or 'failing' its tests). Is this sensible?

(I haven't looked at your PR yet).

fingolfin commented 2 years ago

Indeed, that would be even better. But we still want this PR, I think, so things work right for GAP 4.11.1

fingolfin commented 2 years ago

Oh actually, I see that 4.11 already has a fixed TestPackage, so scratch that -- we may not need this PR here after all