search

gap-infra / integration

A repository for hosting GitHub Actions based GAP-package integration tests
1 stars 4 forks source link

Use GH workflow syntax for container? #8

Open fingolfin opened 2 years ago

fingolfin commented 2 years ago

Could we use the official container support for Github Workflows instead of calling docker manually?

The reason why I think this might be useful (but I might be wrong) is that it should make it convenient to run multiple jobs using the container

Here is an example from the link above:

jobs:
  my_job:
    container:
      image: node:14.16
      env:
        NODE_ENV: development
      ports:
        - 80
      volumes:
        - my_docker_volume:/volume_mount
      options: --cpus 1
wilfwilson commented 2 years ago

I already do this in one place: https://github.com/gap-infra/integration/blob/ef67bc39eba37e26cf2346ebbd8c94d292ef93f0/.github/workflows/pkg-tests.yml#L25

So far, we don't do it anywhere else, because GAP's Docker images (no offence anyone...) are not set up robustly enough.

So for example, calling the step - uses: actions/checkout@v2 in a job running inside one of the GAP Docker images crashes. Also, doing something like - run: gap inside such a Docker image seems to crash (maybe I was just doing something wrong?)

This should be resolvable by 'making better Docker images' (I don't know if any of us have this expertise yet).

fingolfin commented 2 years ago

So maybe @ZachNewbery @alex-konovalov @james-d-mitchell can at some point help with revising the containers. We started a new repo for this at https://github.com/gap-system/containers. Probably should jot down there what all we'd like to have?

FriedrichRober commented 2 years ago

I also was unable to write files while running jobs inside GAP's Docker images, but maybe I tried to write files to some wrong place?