search

gazebo-forks / dart

Dynamic Animation and Robotics Toolkit
http://dartsim.github.io/
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

Add DynamicsAspect aspect to shapes to fix test crash in xenial:i386 #13

Closed azeey closed 3 years ago

azeey commented 3 years ago

Without a DynamicsAspect, a lot of warning messages from ContactConstraint.cc were being printed out that have to do with extracting friction values from a shape that does not have a DynamicsAspect. It seems like the amount of warning messages causes test_Issue1184 to crash.

Signed-off-by: Addisu Z. Taddese addisu@openrobotics.org

scpeters commented 3 years ago

trying to test in CI with a branch:

j-rivero commented 3 years ago

fix_xenial_test_crash...ignition-forks:fix_xenial_test_crash_scpeters

I've fixed the CI on that branch, https://github.com/ignition-forks/dart/runs/1444011155?check_suite_focus=true

azeey commented 3 years ago

Thanks @j-rivero. I will merge those changes into this PR. FYI, the test_Dynamics test is expected to fail.