Remove osg.hpp, render.hpp to fix CI

gazebo-forks / dart

Dynamic Animation and Robotics Toolkit

http://dartsim.github.io/

BSD 2-Clause "Simplified" License

6 stars 5 forks source link

Remove osg.hpp, render.hpp to fix CI #24

Closed scpeters closed 3 years ago

scpeters commented 3 years ago

These header files are auto-generated by cmake and were added for bazel support, but they break cmake when present due to a lack of header guards or a pragma once.

Before creating a pull request

[X] Document new methods and classes
[X] Format new code files using clang-format

Before merging a pull request

[ ] Set version target by selecting a milestone on the right side
[ ] Summarize this change in CHANGELOG.md
[ ] Add unit test(s) for this change

peci1 commented 3 years ago

If there are problems regarding octomap, can it be related to https://github.com/ros/rosdistro/issues/26527 ? It explicitly mentions DART as one of the affected packages.

peci1 commented 3 years ago

Ahh, my bad, that one's for Noetic. However, couldn't the reasoning be similar? Also, the CI is running on Ubuntu 16.04 (if you're talking about the Github Actions CI).

azeey commented 3 years ago

I removed config.hpp in 37420ba. That fixed the build for me locally.

mjcarroll commented 3 years ago

Now CI is failing only because of a known test failure. @mjcarroll , does removing config.hpp break Bazel builds?

It will temporarily, I'm going to fix it in a follow-up PR. Feel free to merge this to get CI turning again.

mjcarroll commented 3 years ago

The follow up fix to this is in #25