search

gazebo-forks / dart

Dynamic Animation and Robotics Toolkit
http://dartsim.github.io/
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

Include DISTRO in version when releasing to avoid problems between distributions #29

Closed j-rivero closed 3 years ago

j-rivero commented 3 years ago

We need to include the distribution name in the version string to avoid problems with source packages for different distributions

j-rivero commented 3 years ago

It would be good to mention that we release for both bionic and focal, so the gbp command has to be ran for each.

Just found that a note is already in the instructions https://github.com/ignition-forks/dart/pull/29/files#diff-87d6a57a759f2386bf9caf5309b9aa0b9ff0ca70f5e38696e114a1ccdb0e785dR43-R46. Is it enough or we need to change it somehow to be clearer?

azeey commented 3 years ago

It would be good to mention that we release for both bionic and focal, so the gbp command has to be ran for each.

Just found that a note is already in the instructions https://github.com/ignition-forks/dart/pull/29/files#diff-87d6a57a759f2386bf9caf5309b9aa0b9ff0ca70f5e38696e114a1ccdb0e785dR43-R46. Is it enough or we need to change it somehow to be clearer?

Oh, the note is fine, I was saying to explicitly state bionic and focal. The note gives focal as an example, but the reader might not know which platforms we are releasing for.

azeey commented 3 years ago

If it's better to keep that information somewhere else, I'm good with merging as is.

j-rivero commented 3 years ago

Oh, the note is fine, I was saying to explicitly state bionic and focal. The note gives focal as an example, but the reader might not know which platforms we are releasing for.

I've modified the note a little bit but feel free to change if you think is easier in any other way.