Port "Conform to ros format for header field frame_id of sensor msgs #195" to all ignition versions

gazebosim / gz-sensors

Provides numerous sensor models designed to generate realistic data from simulation environments.

https://gazebosim.org

Apache License 2.0

58 stars 58 forks source link

Port "Conform to ros format for header field frame_id of sensor msgs #195" to all ignition versions #201

Open halodluc opened 2 years ago

halodluc commented 2 years ago

See #195 for the description. This pull request was merged in branch ign-sensors3, but I think it should be merged probably to all ignition versions. I can confirm that it is necessary for ign-sensors6 and I created a new pull request solving my issue #200 However, I am not sure where else it is necessary and how to do it properly. So this is the reason why I created this issue.

Environment

OS Version: Ubuntu 20.04
Binary installed ignition-edifice with libraries replaced from source ign-sensors6 from #200

ahcorde commented 2 years ago

Hi @halodluc

In general we create forward port (like this one). I will create one this week to push these changes

chapulina commented 2 years ago

Hi @halodluc , thank you for opening this issue and PR #200. As @ahcorde mentioned, we prefer to do forward-ports as described on the contribution guide. I've started with #202 .

halodluc commented 2 years ago

Hi, thank you very much!

ahcorde commented 2 years ago

5 :arrow_right: 6 PR https://github.com/ignitionrobotics/ign-sensors/pull/203

doisyg commented 2 years ago

Already reported there https://github.com/ignitionrobotics/ign-sensors/pull/195, maybe I should open a separate issue but it seems that it works for laserscan msgs but not for pointclouds. I believe the type ignition.msgs.PointCloudPacked is missing the frame field.