The different ways of specifying sensor frame id are being deprecated. This PR makes use of the new //sensor/frame_id sdf element introduced in https://github.com/gazebosim/sdformat/pull/1454. It also deprecates the use of the custom <gz_frame_id> tag. If both tags exist, <frame_id> will override <gz_frame_id>
Test it
All test files have been updated to use <frame_id> instead of <gz_frame_id> and the affected integration tests should pass, e.g. depth, thermal, rgbd camera integration tests.
Checklist
[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
🎉 New feature
Related issue: https://github.com/gazebosim/gz-sensors/issues/306 Depends on: https://github.com/gazebosim/sdformat/pull/1454
Summary
The different ways of specifying sensor frame id are being deprecated. This PR makes use of the new //sensor/frame_id sdf element introduced in https://github.com/gazebosim/sdformat/pull/1454. It also deprecates the use of the custom
<gz_frame_id>tag. If both tags exist,<frame_id>will override<gz_frame_id>Test it
All test files have been updated to use
<frame_id>instead of<gz_frame_id>and the affected integration tests should pass, e.g. depth, thermal, rgbd camera integration tests.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.