khufkens
commented
1 year ago I'll leave @stineb the honour of closing this one before submitting. Thanks Pepa for the final polish.
On Fri, Sep 22, 2023, 11:42 Pepa Arán @.***> wrote:
- Updated the names for the AET, PET and LE outputs, with documentation.
- Wrapper BiomeE examples in \dontrun{} to avoid check error
- Changed title and description to comply with guidelines and set Beni as maintainer for submission
I ran all the checks as in Issue #145 https://github.com/geco-bern/rsofun/issues/145 so it should be ready to go. Please @stineb https://github.com/stineb and @khufkens https://github.com/khufkens take a look and let me know if anything seems wrong. I would like to submit the package asap.
You can view, comment on, or merge this pull request online at:
https://github.com/geco-bern/rsofun/pull/174 Commit Summary
- 2d4ea8a https://github.com/geco-bern/rsofun/pull/174/commits/2d4ea8aac634d5b35806fdbdf6d2f0432914a979 update changes to 4.4
- d52ba67 https://github.com/geco-bern/rsofun/pull/174/commits/d52ba6735e5a42cab7103db40c8f2bad4eac03c9 Merge branch 'geco-bern:master' into master
- 1ad4fec https://github.com/geco-bern/rsofun/pull/174/commits/1ad4feca62551e3ecde9b48fc274ac37226ee49b updated documentation
- 4480778 https://github.com/geco-bern/rsofun/pull/174/commits/44807784ba03503630c359d4d0f3dbcea61b3467 Merge branch 'master' of github.com:pepaaran/rsofun
- 08b2034 https://github.com/geco-bern/rsofun/pull/174/commits/08b20349c79b752d66fcaf2e82ca186680cadaea Merge branch 'geco-bern:master' into master
- cada801 https://github.com/geco-bern/rsofun/pull/174/commits/cada801886135e3ac3168996e739a35223534f1d change names of outputs aet and le
- 2504420 https://github.com/geco-bern/rsofun/pull/174/commits/2504420d70733ec0b6f4a6cd17a1c3f02c752139 Merge branch 'master' of github.com:pepaaran/rsofun
- 5a38660 https://github.com/geco-bern/rsofun/pull/174/commits/5a38660f47887911a82a11c559d659a316a60ad2 update docs
- 9e29dbf https://github.com/geco-bern/rsofun/pull/174/commits/9e29dbf5c22abced57bbb348b773002fd5c87aad update title and description, and set Beni as maintainer for submission
- 042ba60 https://github.com/geco-bern/rsofun/pull/174/commits/042ba60d2e0423f5384f0019e0a40d4324e3c4f5 format description'
- dea872d https://github.com/geco-bern/rsofun/pull/174/commits/dea872d0e872a63273cb19f00a1e2d93d8b5e989 use \dontrun to avoid running BiomeE examples during R CMD check
- 22a54dc https://github.com/geco-bern/rsofun/pull/174/commits/22a54dc92bd0a63ec07203c06bd823c900f44531 \dontrun to avoid check fail
File Changes
(8 files https://github.com/geco-bern/rsofun/pull/174/files)
- M DESCRIPTION https://github.com/geco-bern/rsofun/pull/174/files#diff-9cc358405149db607ff830a16f0b4b21f7366e3c99ec00d52800acebe21b231c (13)
- M NEWS.md https://github.com/geco-bern/rsofun/pull/174/files#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197ea (6)
- M R/run_biomee_f_bysite.R https://github.com/geco-bern/rsofun/pull/174/files#diff-67316ba9238d7dec8194152b0f17647fd00d634d5247d71f86fa11ab299ac19a (4)
- M R/run_pmodel_f_bysite.R https://github.com/geco-bern/rsofun/pull/174/files#diff-12b366e70faae3520305b874093f336360fa72378191ec9b9921f42490b263dd (12)
- M R/runread_biomee_f.R https://github.com/geco-bern/rsofun/pull/174/files#diff-0b0c6768b7aa8b568eb10f952bacc9fec4c69ab6347e99508486568d77a36ad2 (9)
- M man/run_biomee_f_bysite.Rd https://github.com/geco-bern/rsofun/pull/174/files#diff-a8dfef716f91ec7ba4c977cd33738ebcde8c6490268e9646e443ef0450ddc03c (4)
- M man/run_pmodel_f_bysite.Rd https://github.com/geco-bern/rsofun/pull/174/files#diff-cf1b314d813c1c7d6aeb1ed1f9358abf1a7d1896f7846d34f945c0bf40ccd1e6 (8)
- M man/runread_biomee_f.Rd https://github.com/geco-bern/rsofun/pull/174/files#diff-db02ac3435eb7ebef9c85c1243de8c4f55cc49c41597b5ba2ef2bb562abb6764 (9)
Patch Links:
- https://github.com/geco-bern/rsofun/pull/174.patch
- https://github.com/geco-bern/rsofun/pull/174.diff
— Reply to this email directly, view it on GitHub https://github.com/geco-bern/rsofun/pull/174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKKUEVCQRKGUILXPGZFEQDX3VFNVANCNFSM6AAAAAA5CYGZMQ . You are receiving this because you were mentioned.Message ID: @.***>
\dontrun{}to avoid check errorI ran all the checks as in Issue #145 so it should be ready to go. Please @stineb and @khufkens take a look and let me know if anything seems wrong. I would like to submit the package asap.