geco-bern / rsofun

Implements the Simulating Optimal FUNctioning framework for site-scale simulations of ecosystem processes, including model calibration. It contains Fortran 90 modules for the P-model, SPLASH, and BiomeE models.
https://geco-bern.github.io/rsofun/
GNU General Public License v3.0
25 stars 29 forks source link

Implemented feedback from CRAN #177

Closed pepaaran closed 1 year ago

pepaaran commented 1 year ago

Here are the changes suggested by the CRAN reviewers:

In addition, I updated the Sensitivity Analysis and Bayesian Calibration vignette. Now the description of parameter and model uncertainty matches the explanation from the paper and uses consistent language for the credible and predictive intervals.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d5f5b0e) 75.68% compared to head (a6b4755) 75.52%.

:exclamation: Current head a6b4755 differs from pull request most recent head 742c40a. Consider uploading reports for the commit 742c40a to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== - Coverage 75.68% 75.52% -0.17% ========================================== Files 36 36 Lines 4175 4175 ========================================== - Hits 3160 3153 -7 - Misses 1015 1022 +7 ``` | [Files](https://app.codecov.io/gh/geco-bern/rsofun/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/vegetation\_biomee.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3ZlZ2V0YXRpb25fYmlvbWVlLm1vZC5mOTA=) | `57.37% <ø> (ø)` | | | [src/photosynth\_pmodel.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Bob3Rvc3ludGhfcG1vZGVsLm1vZC5mOTA=) | `78.57% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/geco-bern/rsofun/pull/177/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.