search

geco-bern / rsofun

Implements the Simulating Optimal FUNctioning framework for site-scale simulations of ecosystem processes, including model calibration. It contains Fortran 90 modules for the P-model, SPLASH, and BiomeE models.
https://geco-bern.github.io/rsofun/
GNU General Public License v3.0
25 stars 29 forks source link

Amends after CRAN feedback #184

Closed pepaaran closed 1 year ago

pepaaran commented 1 year ago
pepaaran commented 1 year ago

@khufkens @stineb

I'm planning to submit this version of the package again to CRAN. Is everything from the copyright, licensing and authors side ready to go?

khufkens commented 1 year ago

@pepaaran from the licensing point of view everything is ok.

Makes sure to adjust your CRAN submission statement and the NEWS file according to the latest changes, including making the licensing more transparent.

The CRAN submission statement in particular must include how you addressed all comments made in the previous rejection of the package (as with peer review in science). If we didn't address an issue it has to be explained why as well (the motivation must hold).

Does this make sense?

codecov-commenter commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d5f5b0e) 75.68% compared to head (5ea5f88) 75.50%. Report is 26 commits behind head on master.

:exclamation: Current head 5ea5f88 differs from pull request most recent head b8eb6a5. Consider uploading reports for the commit b8eb6a5 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #184 +/- ## ========================================== - Coverage 75.68% 75.50% -0.19% ========================================== Files 36 36 Lines 4175 4172 -3 ========================================== - Hits 3160 3150 -10 - Misses 1015 1022 +7 ``` | [Files](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [R/init\_dates\_dataframe.R](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9pbml0X2RhdGVzX2RhdGFmcmFtZS5S) | `100.00% <ø> (ø)` | | | [R/run\_pmodel\_f\_bysite.R](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9ydW5fcG1vZGVsX2ZfYnlzaXRlLlI=) | `80.57% <100.00%> (-0.44%)` | :arrow_down: | | [R/runread\_biomee\_f.R](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Ui9ydW5yZWFkX2Jpb21lZV9mLlI=) | `100.00% <ø> (ø)` | | | [src/biosphere\_biomee.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Jpb3NwaGVyZV9iaW9tZWUubW9kLmY5MA==) | `100.00% <ø> (ø)` | | | [src/biosphere\_pmodel.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2Jpb3NwaGVyZV9wbW9kZWwubW9kLmY5MA==) | `100.00% <ø> (ø)` | | | [src/classdefs.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2NsYXNzZGVmcy5tb2QuZjkw) | `11.38% <ø> (ø)` | | | [src/datatypes.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2RhdGF0eXBlcy5tb2QuZjkw) | `96.07% <ø> (ø)` | | | [src/forcing\_siterun\_biomee.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2ZvcmNpbmdfc2l0ZXJ1bl9iaW9tZWUubW9kLmY5MA==) | `78.57% <ø> (ø)` | | | [src/forcing\_siterun\_pmodel.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2ZvcmNpbmdfc2l0ZXJ1bl9wbW9kZWwubW9kLmY5MA==) | `86.04% <100.00%> (ø)` | | | [src/gpp\_biomee.mod.f90](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2dwcF9iaW9tZWUubW9kLmY5MA==) | `84.70% <ø> (ø)` | | | ... and [18 more](https://app.codecov.io/gh/geco-bern/rsofun/pull/184?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pepaaran commented 1 year ago

Okay, thanks for the reminder.

I added explanations of how we addressed the issues. Could one of you check it to make sure that the text about the copyright and so on is correct? @khufkens @stineb