geco-bern / rsofun

Implements the Simulating Optimal FUNctioning framework for site-scale simulations of ecosystem processes, including model calibration. It contains Fortran 90 modules for the P-model, SPLASH, and BiomeE models.
https://geco-bern.github.io/rsofun/
GNU General Public License v3.0
25 stars 28 forks source link

Moving generate_biomee/pmodel_driver_data.R from FluxDataKit to rsofun #232

Open marcadella opened 1 week ago

marcadella commented 1 week ago

Related to issue #228 and the fact that we are homogenizing the interfaces: should we move rsofun/data-raw/generate_biomee_driver_data.R to DataFluxKit? It looks like it is related to FluxDataKit/analysis/05_generate_demo_rsofun_drivers.R

fabern commented 1 week ago

This would also affect the generation of pmodel drivers.

The README.md states that the use https://github.com/geco-bern/FluxDataKit/blob/main/analysis/05_generate_demo_rsofun_drivers.R. However, this script has disappeared in the meantime. For the phydro branch the forcing input is anyway extended with the columns: forcing, forcing_24h, forcing_daytime, and forcing_3hrmax

stineb commented 1 week ago

The mentioning of rsofun/data-raw/generate_biomee_driver_data.R can be removed from FluxDataKit. The complete driver object for all sites and years is generated in FluxDataKit (analysis/02_batch_format_rsofun_drivers.R). In rsofun, let's keep the scripts that generate the demo data from that (subsetting to one site and a couple of years within that). This is done by data-raw/generate_biomee_driver_data.R and data-raw/generate_pmodel_driver_data.R. In that sense, I think there is no change needed for creating the P-model drivers. But then, the BiomeE drivers generated by rsofun/data-raw/generate_biomee_driver_data.R may be updated?

fabern commented 6 days ago

The way I understand it, there are the following tasks still to be done: