search

geco-bern / rsofun

Implements the Simulating Optimal FUNctioning framework for site-scale simulations of ecosystem processes, including model calibration. It contains Fortran 90 modules for the P-model, SPLASH, and BiomeE models.
https://geco-bern.github.io/rsofun/
GNU General Public License v3.0
25 stars 29 forks source link

`psi_sat_ref` initialized with negative values in `generate_biomee_driver_data` #239

Closed marcadella closed 3 weeks ago

marcadella commented 1 month ago

psi_sat_ref initialized with negative values in generate_biomee_driver_data, which seems odd. But this value does not seem to be used anywhere (other than computing some derived constant soil parameters, which are themselves not being used). Should we remove all of these?

stineb commented 1 month ago

Yes, remove them. Psi is a water potential (suction head), which is negative in soil.

marcadella commented 3 weeks ago

Keeping it to avoid touching the water model.