geco-bern / rsofun

Implements the Simulating Optimal FUNctioning framework for site-scale simulations of ecosystem processes, including model calibration. It contains Fortran 90 modules for the P-model, SPLASH, and BiomeE models.
https://geco-bern.github.io/rsofun/
GNU General Public License v3.0
25 stars 28 forks source link

instantaneous jmax25 response was not strictly correct #40

Closed yunkepeng closed 3 years ago

yunkepeng commented 3 years ago

I think you convert to jmax25, basing on modified Arrhenius kinetics from Kattge & Knorr (2007).

However, see Smith and Keenan 2020 GCB - table 1 - first line Kattge & Knorr (2007). K25 is not 1, but depended on temperature and vcmax25. If strictly follow their design, then k25 should be updated in our version. Now we assumed jmax25 = jmax / ftemp_inst_jmax, which means k25 still equals to 1. image image

stineb commented 3 years ago

The dependency of Jmax on Vcmax is accounted for in the P-model here through assuming the coordination hypothesis. In this sense, the formulation in Table 1 pasted in above should be regarded as an apparent empirical relationship (against which the P-model-predicted Vcmax25 and Jmax25 can be tested. In other words, for what we're doing here, the scaling applied here should be correct.