search

generoi / genero-design-system

https://gds.generogrowth.com/
MIT License
4 stars 0 forks source link

Feature/media cart part 2 #20

Closed taromorimoto closed 4 years ago

taromorimoto commented 4 years ago

Please check if you notice any problems in the way the components are implemented.

One big thing is how we pass data to more complex components. Basically: "props" vs "child components". I went with a combination of the two for gds-media-card as you can only pass strings to components in html.

taromorimoto commented 4 years ago

I'll merge this but please comment on this and I'll make the potential changes later.