search

generoi / genero-design-system

https://gds.generogrowth.com/
MIT License
4 stars 0 forks source link

feat(gds-link): external attribute #42

Closed oxyc closed 1 year ago

oxyc commented 3 years ago

Provide an external option with an accessible label https://github.com/generoi/julkaisut/blob/5bc291c255ce20ae6081671be9a65cfa015fabc7/web/themes/custom/julkaisut/assets/scripts/app.js#L53:L71

Should it show an icon as well? For accessibility I'd say yes

taromorimoto commented 3 years ago

Sounds good!