generoi / genero-design-system

https://gds.generogrowth.com/
MIT License
4 stars 0 forks source link

gds-label va form label? #49

Closed oxyc closed 1 year ago

oxyc commented 3 years ago

I wonder if label is too much of an abstraction and if we should just use it independently as a form input label instead? Currently tags and accordions use it.

Currently styling tags it's a bit annoying, as menu items used to be.

Thoughts?

taromorimoto commented 3 years ago

@oxyc yeah, I agree. The rational earlier was that we could have a consistent styling across the whole app and kind of enforce a strict set of typography. But as we both agree the solution for this was not very successful. Maybe the consistent styling should be done kind of manually in the css variables level instead of reusing atomic elements.

In a way this kind of goes against the "atomic design system" idea, but maybe more correct way. So maybe those atomic level components should actually be used as they are instead of "converting them to be something else". So for example using gds-label in gds-tag would be incorrect but using gds-tag in gds-media-card would be correct.

Do you agree with this?

oxyc commented 3 years ago

I agree and it sounds like a good rule.

As long as they're in a slot and can be changed it also makes things way easier