search

genielabs / zwave-lib-dotnet

Z-Wave Home Automation library for .NET / Mono
Apache License 2.0
63 stars 37 forks source link

Support for Central Scene command class #14

Closed bluewalk closed 7 years ago

bluewalk commented 7 years ago

I was wondering if there is support for COMMAND_CLASS_CENTRAL_SCENE.

I now own a ZRC-90 scene master, but it only uses the Central Scene command class, as it looks now it is not yet supported by this lib...

At the OpenZWave issues I've found the following for implementation: https://github.com/OpenZWave/open-zwave/issues/367#issuecomment-212574919

I am attempting to add the command class myself, when successful I will create a pull request :)

ben-voss commented 7 years ago

Please see pull request #21 which add your requested support. Since I don't own the device I cannot test the implementation. Would you be able to test this and let me know if there are any problems.

bluewalk commented 7 years ago

In fact I've written the central scene support myself as well and created a pull request a couple of weeks ago 😉

bluewalk commented 7 years ago

See pull request #15

ben-voss commented 7 years ago

Ahh yes so you did. I viewed that pull request on a mobile device that a bit glitchy and only saw the changes for the logging and the timestamp. My apologies - we can ignore this pull request.

bluewalk commented 7 years ago

My PR has been merged so closing this issue.