search

genielabs / zwave-lib-dotnet

Z-Wave Home Automation library for .NET / Mono
Apache License 2.0
63 stars 37 forks source link

Fix version class #2

Closed mdave closed 9 years ago

mdave commented 9 years ago

This PR hopefully fixes the version lookups for active nodes. I think there was a bit of code missing in the latest master, and potentially an issue with the ZWaveNode.GetCommandClass function.

genemars commented 9 years ago

My gosh, sorry about this overlapping, I've fixed it too. Please check it out in the latest master commit. I've also added the "Wait()" method that cause the execution of a command to wait until it's full completition.

mdave commented 9 years ago

No worries, looks good! I have one more small patch for the discovery process which I can put into another merge request if you want. Presently if the device is non-securely added, but supports the security class, it'll get stuck in the security class trying to set the network key. However I can wait if you have other changes that would be going into security.

genemars commented 9 years ago

It's good you can test the Security stuff. I don't have any device supporting it. I've got just a little addition to the ZWaveController class (in the Dispose method), but I'll do this tomorrow.