genomic-medicine-sweden / gms-artic

A nextflow pipeline with a GMS touch for running the ARTIC network's fieldbioinformatics tools (https://github.com/artic-network/fieldbioinformatics).
GNU Affero General Public License v3.0
9 stars 6 forks source link

updated pangolin and dockerhub #13

Closed JD2112 closed 3 years ago

JD2112 commented 3 years ago

The purpose of the code changes are as follows:

What Added updated version of Pangolin v3.0.5 with constellations and scorpio support, #13

Why This changes complete the newest version of Pangolin and add the latest updates for the analysis pipeline.

How I made changes in the environment.yml files for both Illumina and Nanopore workflows and also made some updates (like python>=3.7) on the dependencies.

Testing I tested the pipeline on the local computer as well as on the NGP server, and it is working on both systems.

Standard test procedure

This version is a:

JD2112 commented 3 years ago
  1. changes singularity "process.container" at nextflow.config - containers can be called from local (works with NGP server), dockerhub (doesn't work with NGP server) or singularity library (works with NGP server)
  2. added 'sge' process.executor at nextflow.config
  3. Updated ENV LC_ALL C.UTF-8, ENV LANG C.UTF-8 in docker and singularity env files
  4. update pangolin (v3.0.3), scorpio, constellation, python>=3.7, usher at env*.yml files - latest version needs all these updates to run pangolin.
JD2112 commented 3 years ago

@sylvinite created new pull request after changes.

JD2112 commented 3 years ago

What

Added updated version of Pangolin v3.0.5 with constellations and scorpio support, #13

Why

This changes complete the newest version of Pangolin and add the latest updates for the analysis pipeline.

How

I made changes in the environment.yml files for both Illumina and Nanopore workflows and also made some updates (like python>=3.7) on the dependencies.

Testing

I tested the pipeline on the local computer as well as on the NGP server, and it is working on both systems.