genomic-medicine-sweden / gms-artic

A nextflow pipeline with a GMS touch for running the ARTIC network's fieldbioinformatics tools (https://github.com/artic-network/fieldbioinformatics).
GNU Affero General Public License v3.0
8 stars 6 forks source link

Muscle version 3.8 to allow nanopore analysis with medaka #47

Closed henningonsbring closed 2 years ago

henningonsbring commented 2 years ago

The purpose of the code changes are as follows:

Running nanopore analysis with the most recent container(s?) causes articNcovNanopore:sequenceAnalysisMedaka:articMinIONMedaka to crash. When it worked we used muscle v3.8, recently an unknown update has upgraded muscle to v5.1. In 5.1 the syntax is different and the -in and -out flag has changed names to -align and -output. Further the developers refers to v5 as a "major re-write", therefore it could be risky to use this version.

Me and @talnor have failed to identify which recent dependency upgrade that causes muscle to be upgraded. I suggest we just add muscle=3.8 to the .yml file to make sure analysis wont get stuck on:

Invalid command line
Unknown option in

Standard test procedure

This version is a:

JD2112 commented 2 years ago

Great! Thanks for the info. :) I had the same issue on Tuesday with articNcovNanopore:sequenceAnalysisNanopolish:articMinIONNanopolish. It showed Running: muscle -in 20200311_1427_X1_FAK72834_a3787181_barcode09.muscle.in.fasta -out 20200311_1427_X1_FAK72834_a3787181_barcode09.muscle.out.fasta Command failed:muscle -in 20200311_1427_X1_FAK72834_a3787181_barcode09.muscle.in.fasta -out 20200311_1427_X1_FAK72834_a3787181_barcode09.muscle.out.fasta

I already updated muscle=3.8 in the nanopore yml file (primer-scheme branch; on reply issues #46) which is not merged yet!

Please feel free to merge whenever you have time.