genomic-medicine-sweden / gms-artic

A nextflow pipeline with a GMS touch for running the ARTIC network's fieldbioinformatics tools (https://github.com/artic-network/fieldbioinformatics).
GNU Affero General Public License v3.0
8 stars 6 forks source link

Update nextclade #74

Closed sofstam closed 10 months ago

sofstam commented 1 year ago

The purpose of the code changes are as follows:

Note: The nanopore docker image in master does not work. Fix in separate PR.

Standard test procedure

This version is a:

sofstam commented 1 year ago

Thanks @karlnyr. I do not know why black does not work. I was thinking if the python version in the tests do not match the python version in my conda environment.I will look into this tomorrow.

karlnyr commented 1 year ago

Can you not just run black locally on the following files which seems to fail?

Identified `/home/runner/work/gms-artic/gms-artic` as project root containing a .git directory.
Sources to be formatted: "."
/home/runner/work/gms-artic/gms-artic/.github/data/nanopore/20200311_142[7](https://github.com/genomic-medicine-sweden/gms-artic/actions/runs/4142762909/jobs/7163816675#step:5:8)_X4_FAK72[8](https://github.com/genomic-medicine-sweden/gms-artic/actions/runs/4142762909/jobs/7163816675#step:5:9)34_a3787181/fast5_pass/FAK72834_pass_barcode07_2[9](https://github.com/genomic-medicine-sweden/gms-artic/actions/runs/4142762909/jobs/7163816675#step:5:10)8b7829_0.fast5 ignored: is a symbolic link that points outside /home/runner/work/gms-artic/gms-artic/.github/data/nanopore/20200311_1427_X4_FAK72834_a3787181
/home/runner/work/gms-artic/gms-artic/.github/data/nanopore/20200311_1427_X4_FAK72834_a3787181/fastq_pass/FAK72834_pass_barcode07_298b7829_0.fastq ignored: is a symbolic link that points outside /home/runner/work/gms-artic/gms-artic/.github/data/nanopore/20200311_1427_X4_FAK72834_a3787181
/home/runner/work/gms-artic/gms-artic/.git ignored: matches the --exclude regular expression
/home/runner/work/gms-artic/gms-artic/bin/makeReport.py already well formatted, good job.
/home/runner/work/gms-artic/gms-artic/bin/get_versions.py already well formatted, good job.
would reformat /home/runner/work/gms-artic/gms-artic/bin/qc.py
would reformat /home/runner/work/gms-artic/gms-artic/bin/process_gvcf.py
would reformat /home/runner/work/gms-artic/gms-artic/bin/type_vcf.py
sofstam commented 1 year ago

I have already tested it but the tests still fail. I will try now again.

karlnyr commented 1 year ago

Oh... Well then I understand your confusion - I hope the version matching works!

sofstam commented 1 year ago

The black test is now passing. The nanopore tests are supposed to fail. Just let me know when I can merge @karlnyr