Closed talnor closed 1 year ago
Looks really good. Some structural feedback:
- Two of the self-tests are currently failing
Indeed! They have been for some time as well. I will try to fix it in another PR.
- The building images recipes are better suited in another folder than workflow, which is currently just for the pipeline's subworkflows
I am not sure if GitHub actions will pick them up if we move them elsewhere.
- Both the push recipes look identical. It could also be clearer in the difference of what the regular recipes and the push recipe does.
True! For each build-file, I made one file for the master branch and one to be used for testing in PRs. They differ in when they are activated and where they push the docker image to (gms-artic-nanopore vs gms-artic-nanopore-stage). Perhaps renaming the files makes it more clear?
{build_dockerfile}_on_push.yml -> {build_dockerfile}_master.yml {build_dockerfile}_on_push_stage.yml -> {build_dockerfile}_stage.yml
All the suggestions sounds good to me. Ill unlock the PR.
The purpose of the code changes are as follows:
Will not do
Standard test procedure
This version is a: