search

genthalili / searoute-py

A python package to calculate the shortest sea route between two points on Earth.
Apache License 2.0
63 stars 14 forks source link

Added intersecting points #14

Closed shashankdeshpande closed 1 year ago

shashankdeshpande commented 1 year ago

Implemented this - https://github.com/genthalili/searoute-py/issues/10#issuecomment-1423274055 Fixes - #10

Screenshot 2023-03-30 at 8 17 08 PM
genthalili commented 1 year ago

Hi @shashankdeshpande, thanks for the contribution. I have been using the package for some months now and found some other cases among the ones you mentioned. I went through the cleaning for the totality of the map and I will publish the v1.0.10. I will merge this and then continue the development for v1.0.10. Thanks!

shashankdeshpande commented 1 year ago

@genthalili Thanks for merging this PR. As a part of improvement, we can probably refer to actual port locations and add connection to the nearest LineString if it's missing. Here is the one that we can refer - https://unece.org/trade/cefact/unlocode-code-list-country-and-territory Let me know your thoughts.

genthalili commented 1 year ago

Hi @shashankdeshpande, I'have been working on this lately, and gathered information about ports worldwide.

Right now I'm testing the solution. Basicaly there will be a parameter to include ports (nearest one). Testing the performance right now. It's also a bit connected to issue #2

This will be connected to release 1.1.0 and should be published during next week.

However it would be nice to include rail network at some point in the future.