search

genthalili / searoute-py

A python package to calculate the shortest sea route between two points on Earth.
Apache License 2.0
63 stars 14 forks source link

add traversed passages to properties #31

Closed abajorat closed 3 weeks ago

abajorat commented 3 months ago

sorry, forgot to turn off my auto formatter before commiting, I'll try to fix that, but basically I would just like to get access to the passages that the routes travel along via the properties field

genthalili commented 3 weeks ago

Hi @abajorat, thanks for your contribution! I'll need to double check this possibility and "stress test" this solution with multiple random requests to see how it affects the speed quality. My main concern is when looping and getting edge = M.get_edge_data(previous, now) which could affect the speed for long routes with many edges, maybe there is another way to do it directly in the Marnet class while routing.

Will come back with findings..

genthalili commented 3 weeks ago

hi @abajorat please see #34 latest commit : 48f885d which proposes this option