Routes between US West coast and Asia are plotted incorrectly

genthalili / searoute-py

A python package to calculate the shortest sea route between two points on Earth.

Apache License 2.0

63 stars 14 forks source link

Routes between US West coast and Asia are plotted incorrectly #5

Closed tula-geo closed 1 year ago

tula-geo commented 1 year ago

Hi @genthalili thank you for this great package!

I seem to have a problem plotting routes between the West coast of the US and Asia though... Is this something I am doing wrong or is it a known bug?

Many thanks!

genthalili commented 1 year ago

Hi @tula-geo, can you share origin and destination inputs for this case?

tula-geo commented 1 year ago

@genthalili Thanks for your quick response!

Here the latitudes and longitudes of some examples that went wrong:

Vancouver (49.28497584, -123.1500095) - Tokyo (35.72637966, 139. 6488745)
Singapore (3.2777619, 104.0787642) - San Francisco (37.81212876, -122.3139684)
Shanghai (31.2, 121.8) - Los Angeles (33.7, -118.3)

genthalili commented 1 year ago

@tula-geo Which version are you using? I tried your examples above, and they all look good to me ( also you need to set [long, lat] for origin and destination inputs) :

You should update to the latest version 1.0.8

tula-geo commented 1 year ago

@genthalili Ha, you were right, I had not specified a version when installing the package and was apparently on 1.0.6. This looks much better:

Thanks a lot - this is great stuff!

genthalili commented 1 year ago

@tula-geo great to hear that :)

then I'm closing this issue!