Refactor dem_rsmas.py - Githubissues

geodesymiami / rsmas_insar

RSMAS InSAR code

https://rsmas-insar.readthedocs.io/

GNU General Public License v3.0

59 stars 23 forks source link

Refactor dem_rsmas.py #128

Closed falkamelung closed 3 years ago

falkamelung commented 5 years ago

Maybe Alex could do this one?

This module is based on 1-year old code and some of the new functions are not yet used,

Notes for refactoring (listed according to priority)

for bounddingBox create a call_isce_dem function (similar to call_ssara_dem)
- add a new option --boundingBox_and_ssara. The will first run with --bboundingBox option. If the error occurs 'Error in dem.py: Tiles are missing. Ocean???', then it should restart with --ssara option. This is why we need good functions.
- think about sys.exit. Is that the right way to exit? How to do the error message? Would it be better to use raseException? We need to properly capture the 'Tiles are missing' error. Maybe a David question.
- in ssara part, use GDAL class instead of parsing the gdalinfo output (maybe, ask Yunjun and Sara whether this is possible)
- option when DOWNLOADHOST not equal 'local': this is currently messy (I added it). Look at download_rsmas.py how to it is done.
- use dataset_template (make sure updating works)

falkamelung commented 5 years ago

Check whether USGS DEM server is alive before starting as described here: https://github.com/geodesymiami/rsmas_insar/issues/135 If fails wait 30 seconds, try again, and if it still fails exit with an exception. (if --boundingBox_then_ssara is selected run using ssara also for this error