Open falkamelung opened 4 months ago
sar_plotter:
sarvey
sbas
directory to sb
or sequential
. MiaplPy uses network_sequential
, network_delaunay_4
or network_single_reference
knn
by k_nearest_neighbors
-f config.json
is not given it should use the config.json
if it existsSARvey more urgent suggestions/issues
step_1_arc_coherence_reduced.png
: The title/header does not show what is different to step_1_arc_coherence.png
consider renaming sarvey_mti.py. to sarvey.py ?
code organization as tools/SARvey/src/sarvey/cli for fast --help and so that sarvey --help works (in addition to sarvey.py --help) (check mintpy --help)
It would be really good to use similar names for the networks/parameters as ISCE/miaplpy (need to check Fringe). ISCE uses the term "Sequential" and "number of connections". Here from MiaplPy: Here the MiaplPy options:
I like
star
. Does it involve the selection of abest
reference?consider renaming config.json to sarvey.cfg (there is smallbaselineApp.cfg, miaplpyApp.cfg) ?
window size names. Maybe something similar to miaplPy?
consider some logic to keep a config.json file outside the processing directory from which the local config. json is updated. MintPy has functions for that:
consider supporting MintPy cfg format (and we can have topsStack, MintPy, MiaplPy and sarvey options in one cfg file):
MintPy example:
pip install PySide6 (I had to uninstall?Have to check)
consider using --dostep step_name and --start step_name --end step_name following ISCE and MintPy:
https://github.com/isce-framework/isce2?tab=readme-ov-file#running-isce-with-steps