search

geotopmodel / geotop

GEOtop is a distributed model of the mass and energy balance of the hydrological cycle, which is applicable to simulations in continuum in small catchments. GEOtop deals with the effects of topography on the interaction between energy balance and hydrological cycle with peculiar solutions.
GNU General Public License v3.0
38 stars 29 forks source link

DtPlotDischarge behaves differently in version 2.0 and 2.1 #23

Open cozzini opened 7 years ago

cozzini commented 7 years ago

if DtPlotDischarge is lower than timestep it is automatically set to Dt (each hours) in version 2.0.0 while in version 2.1 is simply ignored. This means that discharge.txt file is just one line that containts headers on version 2.1.

ssenoner commented 5 years ago

Hi @cozzini , DtPlotDischarge is compared to a value called minDt and not Dt: https://github.com/geotopmodel/geotop/blob/eaa345c0cbe4bd6d84a26a0d077ed47032d016f2/src/geotop/parameters.cc#L1427 there is no change in this behavior between 2.0 and 2.1, also minDt is initialized with the same value, but the value of minDt is initialized but in 2.1 never changed. On the other side minDt is initialized to a very high value: https://github.com/geotopmodel/geotop/blob/eaa345c0cbe4bd6d84a26a0d077ed47032d016f2/src/geotop/parameters.cc#L1358 again, also 2.0 uses the same value for initialization of minDt What do you think about it?

ssenoner commented 5 years ago

I looked at the next steps. So the Point where Dtplot_discharge is changed in 2.0 was a function called set_time_step. In 2.0 you had the chance to execute a Simulation more often and probably with different dt values, as far as I understood this has been removed in 2.1, but the correction of this single Dt values also was removed.

ssenoner commented 5 years ago

I saw that in the 3D example snow_dstr_SENSITIVITY we faced this bug, when I created the discharge file in fact it was different than the one calculated by SE27XX, but I think this is already known that there are some differences, Right?

ssenoner commented 5 years ago

In fact same can be done not only for discharge, but also for Basin and Point.....