getappmap / appmap-intellij-plugin

MIT License
38 stars 9 forks source link

Support `open-location` for Navie webview #678

Closed jansorg closed 7 months ago

jansorg commented 7 months ago

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/677

This PR adds support for Navie's open-location. Numbers of name:line-line are taken as 1-based and are adjusted to the IDE's 0-based numbers. Relative paths are looked up in the available project files to find the best match.

I tested opening regular source files and also opening an AppMap using pre-release https://github.com/getappmap/appmap-js/releases/tag/%40appland%2Fappmap-v3.137.0

This PR is supporting both variants of the open-location message: open-location "path/to/file" and open-location "path/to/file", "/root/dir". I wasn't able to test the 2nd variant, but AFAIK it would need a new release with an updated Navie webview, anyway.

github-actions[bot] commented 7 months ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
API changes :zero: No API changes
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns :white_check_mark: None detected
New AppMaps :star: 1 new junit test

⭐ New AppMaps

[junit] App map file lookup scoped locate filename by index from plugin-core/src/test/java/appland/files/AppMapFileLookupTest.java:36

appland-release commented 7 months ago

:tada: This PR is included in version 0.65.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: