search

getappmap / appmap-intellij-plugin

MIT License
38 stars 9 forks source link

fix: only include source directories in config #699

Closed apotterri closed 6 months ago

apotterri commented 6 months ago

When generating the default appmap.yml, make sure only source directories are included.

Fixes #690

github-actions[bot] commented 6 months ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
API changes :zero: No API changes
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns :white_check_mark: None detected
New AppMaps :star: 2 new junit tests

⭐ New AppMaps

[junit] App map java package config config created in root from plugin-java/src/test/java/appland/execution/AppMapJavaPackageConfigTest.java:89

[junit] App map java package config ignore resources from plugin-java/src/test/java/appland/execution/AppMapJavaPackageConfigTest.java:73

apotterri commented 6 months ago

Thanks for reviewing these changes. I pulled in the suggestions you made.

As far as edge cases go, I feel like we've already spent enough time on this, maybe more than it really merited. I think we've got the majority of the cases covered. If we run into a case where we can't derive the correct location for appmap.yml from the project, we'll fall back to creating it in the current working directory. This seems to me like it's good enough for now.