getappmap / appmap-intellij-plugin

MIT License

38 stars 9 forks source link

Pass code editor to Navie JSON-RPC server #709

Closed jansorg closed 5 months ago

jansorg commented 5 months ago

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/708

Passes environment variable "APPMAP_CODE_EDITOR" to the Navie JSON-RPC process.

For simplicity and compatibility, we're currently using the SDK's built-in application info strings. For IntelliJ Community, the value is "IntelliJ IDEA 2023.2 by JetBrains s.r.o.".

This should work well for products like WebStorm or Google's Android Studio.

github-actions[bot] commented 5 months ago

AppMap runtime code review

Summary	Status
Failed tests	:white_check_mark: All tests passed
API changes	:zero: No API changes
Security flaws	:white_check_mark: None detected
Performance problems	:white_check_mark: None detected
Code anti-patterns	:white_check_mark: None detected
New AppMaps	:star: 1 new junit test

⭐ New AppMaps

[junit] Default app land json rpc service code editor info from plugin-core/src/test/java/appland/rpcService/DefaultAppLandJsonRpcServiceTest.java:108