jansorg commented 6 months ago

This PR

always adds the stats property to the JSON, which is passed to the AppMap webview. If the CLI failed to return the stats, then an empty array is used for stats
does not pass AppMap property findings to the AppMap webview for giant AppMaps, but only for regular and large AppMap files. Previously, findings were always attached

Although the old code already added stats, it wasn't always added. This PR now follows the VSCode plugin's code more closely.

This is what I'm seeing for large AppMaps (tested locally by changing the threshold, I don't have a giant AppMap file available here):

github-actions[bot] commented 6 months ago

AppMap runtime code review

Summary	Status
Failed tests	:white_check_mark: All tests passed
API changes	:zero: No API changes
Security flaws	:white_check_mark: None detected
Performance problems	:white_check_mark: None detected
Code anti-patterns	:white_check_mark: None detected
New AppMaps	:zero: No new AppMaps

appland-release commented 5 months ago

:tada: This PR is included in version 0.68.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

getappmap / appmap-intellij-plugin