jansorg commented 3 months ago

https://github.com/getappmap/appmap-intellij-plugin/pull/759/commits/dd46266f6a10f45c5dd8e6c4c9410dae2dc658cb For Navie and other code the presence of appmap.yml files in the project is detected. We used the SDK's FilenameIndex, which should be suitable for tasks like this. But it proved to expensive to call because it attempted to update a lot of index data of files we don't care about. This commit adds an index only for the filename indexing of appmap.yml files to make the lookup much faster and cheaper.
https://github.com/getappmap/appmap-intellij-plugin/pull/759/commits/553decd799abb1b466d26e22fcdf8fc9a8b6c3e9 changes the handling of generic filesystem refresh events. Previously, every refresh and even a refresh of non-AppMap files, triggered an update of the Navie editor. Because there can be a lot of file changes in the background, the Navie editor was updated a lot. Every update triggered a somewhat expensive lookup of AppMaps and appmap.yml files. The generic refresh does not update the Navie editor anymore, but updates of .appmap.json, appmap.yml and a status change of indexing does update it.

github-actions[bot] commented 3 months ago

AppMap runtime code review

Summary	Status
Failed tests	:white_check_mark: All tests passed
API changes	:zero: No API changes
Security flaws	:white_check_mark: None detected
Performance problems	:white_check_mark: None detected
Code anti-patterns	:white_check_mark: None detected
New AppMaps	:zero: No new AppMaps

appland-release commented 3 months ago

:tada: This issue has been resolved in version 0.73.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

getappmap / appmap-intellij-plugin