search

getappmap / appmap-intellij-plugin

MIT License
38 stars 9 forks source link

Improve test setup and reenable two tests #762

Closed jansorg closed 2 months ago

jansorg commented 3 months ago

This is merging some changes of outdated PR https://github.com/getappmap/appmap-intellij-plugin/pull/674

This should make tests more reliable and easier to debug. Async process execution is disabled for tests now and this should avoid some of the unstable tests we've observed in the past.

The AppMap report is showing nicely that there this PR un-ignored two of the previously flaky tests :)

A user-visible fix is https://github.com/getappmap/appmap-intellij-plugin/pull/762/commits/96cc6c2cfbfc7c86fb07504eba50d207e98dd310, which fixes the restart of the JSON-RPC server after too many terminations of the process.

github-actions[bot] commented 3 months ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
API changes :zero: No API changes
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns :white_check_mark: None detected
New AppMaps :star: 2 new junit tests

⭐ New AppMaps

[junit] Default command line service sibling directories from plugin-core/src/test/java/appland/cli/DefaultCommandLineServiceTest.java:163

[junit] Findings manager findings VS code system from plugin-core/src/test/java/appland/problemsView/FindingsManagerTest.java:40

appland-release commented 2 months ago

:tada: This issue has been resolved in version 0.73.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: